You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
78 lines
2.2 KiB
78 lines
2.2 KiB
4 months ago
|
// Copyright 2020 The Android Open Source Project
|
||
|
|
//
|
||
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
|
|
// you may not use this file except in compliance with the License.
|
||
|
|
// You may obtain a copy of the License at
|
||
|
|
//
|
||
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||
|
|
//
|
||
|
|
// Unless required by applicable law or agreed to in writing, software
|
||
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
|
|
// See the License for the specific language governing permissions and
|
||
|
|
// limitations under the License.
|
||
|
|
|
||
|
|
package rust
|
||
|
|
|
||
|
|
import (
|
||
|
|
"testing"
|
||
|
|
|
||
|
|
"android/soong/android"
|
||
|
|
)
|
||
|
|
|
||
|
|
func TestClippy(t *testing.T) {
|
||
|
|
|
||
|
|
bp := `
|
||
|
|
// foo uses the default value of clippy_lints
|
||
|
|
rust_library {
|
||
|
|
name: "libfoo",
|
||
|
|
srcs: ["foo.rs"],
|
||
|
|
crate_name: "foo",
|
||
|
|
}
|
||
|
|
// bar forces the use of the "android" lint set
|
||
|
|
rust_library {
|
||
|
|
name: "libbar",
|
||
|
|
srcs: ["foo.rs"],
|
||
|
|
crate_name: "bar",
|
||
|
|
clippy_lints: "android",
|
||
|
|
}
|
||
|
|
// foobar explicitly disable clippy
|
||
|
|
rust_library {
|
||
|
|
name: "libfoobar",
|
||
|
|
srcs: ["foo.rs"],
|
||
|
|
crate_name: "foobar",
|
||
|
|
clippy_lints: "none",
|
||
|
|
}`
|
||
|
|
|
||
|
|
var clippyLintTests = []struct {
|
||
|
|
modulePath string
|
||
|
|
fooFlags string
|
||
|
|
}{
|
||
|
|
{"", "${config.ClippyDefaultLints}"},
|
||
|
|
{"external/", ""},
|
||
|
|
{"hardware/", "${config.ClippyVendorLints}"},
|
||
|
|
}
|
||
|
|
|
||
|
|
for _, tc := range clippyLintTests {
|
||
|
|
t.Run("path="+tc.modulePath, func(t *testing.T) {
|
||
|
|
|
||
|
|
result := android.GroupFixturePreparers(
|
||
|
|
prepareForRustTest,
|
||
|
|
// Test with the blueprint file in different directories.
|
||
|
|
android.FixtureAddTextFile(tc.modulePath+"Android.bp", bp),
|
||
|
|
).RunTest(t)
|
||
|
|
|
||
|
|
r := result.ModuleForTests("libfoo", "android_arm64_armv8-a_dylib").MaybeRule("clippy")
|
||
|
|
android.AssertStringEquals(t, "libfoo flags", tc.fooFlags, r.Args["clippyFlags"])
|
||
|
|
|
||
|
|
r = result.ModuleForTests("libbar", "android_arm64_armv8-a_dylib").MaybeRule("clippy")
|
||
|
|
android.AssertStringEquals(t, "libbar flags", "${config.ClippyDefaultLints}", r.Args["clippyFlags"])
|
||
|
|
|
||
|
|
r = result.ModuleForTests("libfoobar", "android_arm64_armv8-a_dylib").MaybeRule("clippy")
|
||
|
|
if r.Rule != nil {
|
||
|
|
t.Errorf("libfoobar is setup to use clippy when explicitly disabled: clippyFlags=%q", r.Args["clippyFlags"])
|
||
|
|
}
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|